Add an Option to inject pagedjs polyfill #656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@freekmurze sorry for the ping, but is there any feedback on this? 🤔 |
|
I would also be interested in this being merged |
|
Dear contributor, because this pull request seems to be inactive for quite some time now, I've automatically closed it. If you feel this pull request deserves some attention from my human colleagues feel free to reopen it. |
|
@freekmurze any feedback? re-open? keep it closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While paged.js works well when it's directly included in the head tag of the Site when it's added via script injection (
$browser->setOption('addScriptTag', '{"url": "https://unpkg.com/pagedjs/dist/paged.polyfill.js"}')) there need to be done some evaluation a wait for a specific selector is added.Im not sure about the option setter, it might be better to support the json syntax from above so one could include a local
pathversion of pagedjs as well. For our case using the remote one is fine, but i could change that if you'd prefer the other variant :)